[chore] [cmd/schemagen] Fix pattern propagation and enhance error handling#49016
Open
jkoronaAtCisco wants to merge 2 commits into
Open
[chore] [cmd/schemagen] Fix pattern propagation and enhance error handling#49016jkoronaAtCisco wants to merge 2 commits into
jkoronaAtCisco wants to merge 2 commits into
Conversation
…e and resolver methods
|
Hey @jkoronaAtCisco - if these are not urgent, would it be possible to wait for these contributions to go in, and maybe make the contribution at githu.com/open-telemetry/opentelemetry-collector? We're in the middle of moving schemagen to that repository with these two PRs:
At the request of @dmitryax, to prevent circular references to the tool. I hope that's OK. 🙏 Let me know if I can work with you, or help, to make it work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR provides fix for pattern propagation in schema resolver (when
-rflag set) and improves overall error handling for better debugging.Testing
Unit tests updated.
Authorship