[processor/transform] Optimize limit_buckets compaction divisor#49021
Open
dmitryax wants to merge 1 commit into
Open
[processor/transform] Optimize limit_buckets compaction divisor#49021dmitryax wants to merge 1 commit into
dmitryax wants to merge 1 commit into
Conversation
Use the ceiling bucket-count-to-limit divisor to compact limit_buckets histograms in one pass, keeping the result within the configured limit while avoiding an extra halving pass. Update the docs and add regression coverage for the 10 buckets to 4 buckets case. Assisted-by: OpenAI Codex
dmitryax
requested review from
a team,
TylerHelmuth,
bogdandrutu,
edmocosta and
evan-bradley
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compacts
merge_histogram_buckets(..., method="limit_buckets")with the minimum divisor that keeps the output at or below the requested bucket limit, instead of repeatedly halving pairs. Updates docs and adds regression coverage for 10 buckets limited to 4.Fixes #49020