[receiver/httpcheck] Use confighttp defaulting constructor#49357
Open
swiatekm wants to merge 2 commits into
Open
[receiver/httpcheck] Use confighttp defaulting constructor#49357swiatekm wants to merge 2 commits into
swiatekm wants to merge 2 commits into
Conversation
Each target's embedded confighttp.ClientConfig is created while decoding a list element, so it defaults to a zero value. Seed NewDefaultClientConfig in the target's Unmarshal (resetting the other constructor-set fields to preserve existing behavior).
swiatekm
changed the title
swiatekm
changed the title
atoulme
added
Skip Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The receiver creates a confighttp client for each target. The targets are an array, so during unmarshalling, they get zero values of confighttp.ClientConfig, which isn't correct. Use a custom unmarshaller to inject values from the ClientConfig defaulting constructor. The injected values are then reset, so this change is effectively a no-op.
Link to tracking issue
Part of #49308. Missed it in #49307.
Testing
Existing tests suffice.
Authorship