fix(statsdreceiver): apply histogram max_size to the correct metric category#49418
Draft
shachar-ash wants to merge 2 commits into
Draft
fix(statsdreceiver): apply histogram max_size to the correct metric category#49418shachar-ash wants to merge 2 commits into
shachar-ash wants to merge 2 commits into
Conversation
…ategory Initialize() wired the timer_histogram_mapping config to the wrong ObserverCategory: the histogram/distribution case wrote the exponential-histogram config (max_size) onto timerEvents, and the timing case wrote explicit buckets onto histogramEvents. Because |h/|d metrics read histogramEvents.histogramConfig (which was never set), a max_size configured on a distribution/histogram mapping was silently ignored and those metrics always used the go-expohisto default (160); explicit buckets on a timing mapping were likewise dropped. Assign each statsd_type's config to the category that actually serves it. Adds a regression test that configures a distribution-only mapping with max_size=10 over a 2**10 input range and asserts the histogram collapses to scale 0 / 10 buckets (fails before the fix, where the default size is used). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Contributor
|
Please review the EasyCLA step, fix the changelog and mark ready to review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize() wired the timer_histogram_mapping config to the wrong ObserverCategory: the histogram/distribution case wrote the exponential-histogram config (max_size) onto timerEvents, and the timing case wrote explicit buckets onto histogramEvents. Because |h/|d metrics read histogramEvents.histogramConfig (which was never set), a max_size configured on a distribution/histogram mapping was silently ignored and those metrics always used the go-expohisto default (160); explicit buckets on a timing mapping were likewise dropped.
Assign each statsd_type's config to the category that actually serves it. Adds a regression test that configures a distribution-only mapping with max_size=10 over a 2**10 input range and asserts the histogram collapses to scale 0 / 10 buckets (fails before the fix, where the default size is used).
Description
Link to tracking issue
Fixes