Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .chloggen/mowies-fix-checksums.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: releases

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix artifact checksum files being incomplete and split between Linux/Darwin and Windows.

# One or more tracking issues or pull requests related to the change
issues: [1002, 1086]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
This fixes a bug that occurred because releases for Windows and other Platforms are split.
The Windows release always overwrote the checksum files already created for Linux and Darwin and so, only
the Windows checksums were accessible in the end.

This change is breaking because checksum files for Linux/Darwin and Windows are now split.

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []

2 changes: 1 addition & 1 deletion cmd/goreleaser/internal/configure.go
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ func (b *distributionBuilder) sboms() []config.SBOM {
func (b *distributionBuilder) WithDefaultChecksum() *distributionBuilder {
b.configFuncs = append(b.configFuncs, func(d *distribution) {
b.dist.checksum = config.Checksum{
NameTemplate: fmt.Sprintf("{{ .ProjectName }}_%v_checksums.txt", d.name),
NameTemplate: fmt.Sprintf("{{ .ProjectName }}_%v{{ if .Runtime.Goos == \"windows\" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt", d.name),
}
})
return b
Expand Down
2 changes: 1 addition & 1 deletion distributions/otelcol-contrib/.goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ nfpms:
builds:
- otelcol-contrib-linux
checksum:
name_template: '{{ .ProjectName }}_otelcol-contrib_checksums.txt'
name_template: '{{ .ProjectName }}_otelcol-contrib{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
dockers:
- goos: linux
goarch: "386"
Expand Down
2 changes: 1 addition & 1 deletion distributions/otelcol-ebpf-profiler/.goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ archives:
builds:
- otelcol-ebpf-profiler-linux
checksum:
name_template: '{{ .ProjectName }}_otelcol-ebpf-profiler_checksums.txt'
name_template: '{{ .ProjectName }}_otelcol-ebpf-profiler{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
dockers:
- goos: linux
goarch: amd64
Expand Down
2 changes: 1 addition & 1 deletion distributions/otelcol-k8s/.goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ archives:
- otelcol-k8s-linux
- otelcol-k8s-windows
checksum:
name_template: '{{ .ProjectName }}_otelcol-k8s_checksums.txt'
name_template: '{{ .ProjectName }}_otelcol-k8s{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
dockers:
- goos: linux
goarch: amd64
Expand Down
2 changes: 1 addition & 1 deletion distributions/otelcol-otlp/.goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ nfpms:
builds:
- otelcol-otlp-linux
checksum:
name_template: '{{ .ProjectName }}_otelcol-otlp_checksums.txt'
name_template: '{{ .ProjectName }}_otelcol-otlp{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
dockers:
- goos: linux
goarch: "386"
Expand Down
2 changes: 1 addition & 1 deletion distributions/otelcol/.goreleaser.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ nfpms:
builds:
- otelcol-linux
checksum:
name_template: '{{ .ProjectName }}_otelcol_checksums.txt'
name_template: '{{ .ProjectName }}_otelcol{{ if .Runtime.Goos == "windows" }}_{{ .Runtime.Goos }}{{ end }}_checksums.txt'
dockers:
- goos: linux
goarch: "386"
Expand Down