Skip to content

Switch from Prometheus self-scrape to OTLP telemetry #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Switch from Prometheus self-scrape to OTLP telemetry #1157

wants to merge 3 commits into from

Conversation

@lakkawardhananjay
Copy link

@lakkawardhananjay lakkawardhananjay commented Sep 2, 2025 •
edited by mowies
Loading

  • Removed Prometheus receiver configuration from:
    • distributions/otelcol/config.yaml
    • distributions/otelcol-contrib/config.yaml
    • tests/golden/config.yaml
  • Added service.telemetry.metrics to expose internal metrics in OTLP
  • Updated metrics pipeline to use otlp receiver and debug exporter

fixes #836

@lakkawardhananjay lakkawardhananjay requested a review from a team as a code owner September 2, 2025 16:52
bogdandrutu
bogdandrutu reviewed Sep 2, 2025
View reviewed changes
distributions/otelcol-contrib/config.yaml Outdated
Comment on lines 40 to 43
telemetry:
metrics:
level: basic
address: 0.0.0.0:8888
Copy link
Member

@bogdandrutu bogdandrutu Sep 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work. See https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#v1340v01280 and the telemetry.disableAddressFieldForInternalTelemetry

Copy link
Author

@lakkawardhananjay lakkawardhananjay Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification @bogdandrutu .
With just level: basic, the metrics will be exposed on the default (localhost) endpoint, as outlined in the latest documentation. I'll recommit with the removed one accordingly.
Much appreciated!

@lakkawardhananjay
Copy link
Author

lakkawardhananjay commented Sep 8, 2025 •
edited
Loading

hey @bogdandrutu please review it.
@ChrsMark plese review it.

@mowies mowies changed the title This PR switches from Prometheus self-scrape to OTLP telemetry and updates the pipeline.(fixes #836 ) Switch from Prometheus self-scrape to OTLP telemetry Sep 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Sep 30, 2025
@mowies
Copy link
Member

mowies commented Sep 30, 2025

@bogdandrutu @ChrsMark could you pls take another look at this? 🙏🏼

@github-actions github-actions bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 16, 2025
@mowies mowies requested a review from atoulme October 20, 2025 09:08
@mowies mowies removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 4, 2025
@mowies mowies removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-releases-approvers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@atoulme atoulme Awaiting requested review from atoulme

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the config.yaml of distributions to use the OTLP receiver instead of Prometheus

3 participants

@lakkawardhananjay @mowies @bogdandrutu