Conversation
mowies
left a comment
There was a problem hiding this comment.
LGTM
But this should have at least another review to get more confidence in merging it.
Also, please do a test release in your fork and attach the link here to be sure that everything works in the release pipelines.
atoulme
left a comment
There was a problem hiding this comment.
Thank you for your PR. Please see my comment and please engage with the collector SIG to get riscv64 supported.
|
I added that to the Collector SIG (EU/ET) meeting notes (not sure if that's a valid SIG tho). I'll join next meeting to discuss. When it comes to release - I don't have the Pro license key, so I think I won't be able to run it :/ |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description New Tier 3 platform: `riscv64` architecture is now included, allowing the collector to be built and distributed for this platform. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #41507 X-Ref: open-telemetry/opentelemetry-collector-releases#969 <!--Describe what testing was performed and which tests were added.--> #### Testing I’ve performed basic compilation as well as starting collector inside a linux/riscv64 container (`docker.io/riscv64/debian`). --------- Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description New Tier 3 platform: `riscv64` architecture is now included, allowing the collector to be built and distributed for this platform. <!-- Issue number if applicable --> #### Link to tracking issue Fixes #13462 X-Ref: open-telemetry/opentelemetry-collector-releases#969 <!--Describe what testing was performed and which tests were added.--> #### Testing I’ve performed basic compilation as well as starting collector inside a linux/riscv64 container (`docker.io/riscv64/debian`). <!--Describe the documentation added.--> #### Documentation Added myself as a contact point to `platform-support.md` document. --------- Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
|
I'll rebase and fix the issues later today |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description New Tier 3 platform: `riscv64` architecture is now included, allowing the collector to be built and distributed for this platform. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41507 X-Ref: open-telemetry/opentelemetry-collector-releases#969 <!--Describe what testing was performed and which tests were added.--> #### Testing I’ve performed basic compilation as well as starting collector inside a linux/riscv64 container (`docker.io/riscv64/debian`). --------- Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Co-Authored-By: @mowies Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
|
i will merge this on thursday, to give people more time to review |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description New Tier 3 platform: `riscv64` architecture is now included, allowing the collector to be built and distributed for this platform. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#41507 X-Ref: open-telemetry/opentelemetry-collector-releases#969 <!--Describe what testing was performed and which tests were added.--> #### Testing I’ve performed basic compilation as well as starting collector inside a linux/riscv64 container (`docker.io/riscv64/debian`). --------- Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
|
small fix as a follow up for this: #1090 |
New Tier 3 platform:
riscv64architecture is now included, allowing the collector to be built and distributed for this platform.Fixes #968