Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Feb 25, 2025

Description

The current implementation is not working in the sample projects. I reviewed the PR that introduced these changes and found no explanation for them. I believe it’s reasonable to revert these changes, so I’ve created this PR.

Please let me know if I’ve missed anything. Thank you!

Link to tracking issue

Fixes #12298

Testing

$ cd cmd/mdatagen 
$ go install .
$ make generate 
$ git status  # run this to check there is no change in the generated files 
$ make test

Documentation

@ghost ghost requested review from a team and dmitryax as code owners February 25, 2025 06:41
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@ghost
Copy link
Author

ghost commented Feb 26, 2025

the cla has been signed, could you please have a look? thanks!

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (6e82944) to head (c8b2b75).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12477   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         470      470           
  Lines       25372    25372           
=======================================
  Hits        23353    23353           
  Misses       1612     1612           
  Partials      407      407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added this pull request to the merge queue Feb 26, 2025
@ghost
Copy link
Author

ghost commented Feb 26, 2025

looks like easycla still got stuck here

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2025
@dmitryax dmitryax added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 26, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 27, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 27, 2025
@bogdandrutu bogdandrutu removed this pull request from the merge queue due to a manual request Feb 27, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 27, 2025
bogdandrutu added a commit that referenced this pull request Feb 28, 2025
Fixes #12298

Inspired by
#12477,
but looks like that PR is hard to pass queue merge.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu
Copy link
Member

Please rebase.

Will Li added 2 commits March 4, 2025 18:23
…h/opentelemetry-collector into new-fix-mdatagen-internal-tests
@bogdandrutu bogdandrutu enabled auto-merge March 4, 2025 12:26
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 4, 2025
@dmitryax
Copy link
Member

dmitryax commented Mar 4, 2025

Done in #12523

@dmitryax dmitryax closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mdatagen: metrics.go.tmpl broken filter import

2 participants