Skip to content

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Feb 25, 2025

Description

Depends on #12478, deprecates methods that are unnecessary

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Feb 25, 2025
@mx-psi mx-psi force-pushed the mx-psi/deprecate-func-methods branch from 1e7ee27 to b44fee9 Compare February 26, 2025 12:35
@mx-psi mx-psi force-pushed the mx-psi/deprecate-func-methods branch from b44fee9 to 26f757d Compare February 26, 2025 12:36
@mx-psi mx-psi marked this pull request as ready for review February 26, 2025 12:36
@mx-psi mx-psi requested a review from a team as a code owner February 26, 2025 12:36
@jade-guiton-dd
Copy link
Contributor

Do you think this panic in contrib-tests is relevant? It looks to me like that test should have panicked even with the previous code however (creating an auth.NewClient() with no options should result in a segfault when trying to call the function, whether it's embedded or not)

@mx-psi
Copy link
Member Author

mx-psi commented Feb 27, 2025

Do you think this panic in contrib-tests is relevant? It looks to me like that test should have panicked even with the previous code however (creating an auth.NewClient() with no options should result in a segfault when trying to call the function, whether it's embedded or not)

I added the nil check present in the Func types: 38d366c. I think that should solve the panic, thanks for pointing this out

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (58f3efb) to head (7d4cb15).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12480      +/-   ##
==========================================
- Coverage   92.16%   92.05%   -0.11%     
==========================================
  Files         465      467       +2     
  Lines       25201    25267      +66     
==========================================
+ Hits        23226    23260      +34     
- Misses       1576     1605      +29     
- Partials      399      402       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi enabled auto-merge February 27, 2025 12:36
@mx-psi mx-psi added this pull request to the merge queue Feb 27, 2025
Merged via the queue into open-telemetry:main with commit 60e5fd0 Feb 27, 2025
54 checks passed
@mx-psi mx-psi deleted the mx-psi/deprecate-func-methods branch February 27, 2025 13:16
github-merge-queue bot pushed a commit that referenced this pull request Mar 4, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Follows #12480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:blocker The issue must be resolved before cutting the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants