-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[component] Add namespace parameter to component.BuildInfo #12508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component] Add namespace parameter to component.BuildInfo #12508
Conversation
10a0443 to
832d433
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12508 +/- ##
==========================================
+ Coverage 92.18% 92.20% +0.02%
==========================================
Files 469 469
Lines 25390 25395 +5
==========================================
+ Hits 23405 23416 +11
+ Misses 1574 1568 -6
Partials 411 411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0aced7 to
0e8b029
Compare
742e731 to
d5a3432
Compare
evan-bradley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
9e2fe4e to
b3427b6
Compare
b3427b6 to
03bb387
Compare
03bb387 to
146215c
Compare
|
Contrib tests failing |
|
I am not sure I understand, how this. Why do you not configure the "service.namespace" in the |
bogdandrutu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The service.namespace is a runtime identification configuration and not a build time identification configuration, so I am confused why we need a change to the build info.
|
@dpaasman00 I've discussed this offline with other core leads and received some feedback that we may need to make some changes. Could you make the following updates to this PR?
|
|
A relatively minor aside: I read through the docs again and saw this:
I don't think this strictly impacts anything here since we can define the semantics if we concatenate the distro and binary inside |
|
After spending some time thinking about this, I agree that
I understand this approach would take a while since we're changing the semantic conventions and BuildInfo, but I do think it is a better approach to the original problem this PR was trying to solve. @evan-bradley @bogdandrutu What do you think of this approach? |
|
Thanks for your thoughts, I'm largely in agreement with everything you wrote. There is an existing proposal for something similar, but under the |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Adds a new field to
component.BuildInfoto facilitate support for reporting theservice.namespacesemantic convention in OpAMP. Includes corresponding updates to resource attributes reported by the collector. Also adds a new parameter to the builder configuration to facilitate setting this via the OCB.Link to tracking issue
Fixes #12505
Need follow up PR to OpAMP extension making use of this value.
Testing
Relevant unit tests updated.
Running the updated otelcorecol with logging enabled in
service.telemetryand the new resource attribute forservice.namespaceshows up. This was done sending to another collector running the otlp receiver and logging via the debug exporter.02-26-25_monitoring-output.txt
Documentation