Skip to content

[chore] fix typos in error messages "Failed to convert metrics" #12526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeboten merged 1 commit into from
Feb 28, 2025
Merged

[chore] fix typos in error messages "Failed to convert metrics" #12526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/exporterhelper/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func newConsumeLogs(converter RequestFromLogsFunc, be *internal.BaseExporter, lo
return func(ctx context.Context, ld plog.Logs) error {
req, err := converter(ctx, ld)
if err != nil {
logger.Error("Failed to convert metrics. Dropping data.",
logger.Error("Failed to convert logs. Dropping data.",
zap.Int("dropped_log_records", ld.LogRecordCount()),
zap.Error(err))
return consumererror.NewPermanent(err)
Expand Down
2 changes: 1 addition & 1 deletion exporter/exporterhelper/traces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func newConsumeTraces(converter RequestFromTracesFunc, be *internal.BaseExporter
return func(ctx context.Context, td ptrace.Traces) error {
req, err := converter(ctx, td)
if err != nil {
logger.Error("Failed to convert metrics. Dropping data.",
logger.Error("Failed to convert traces. Dropping data.",
zap.Int("dropped_spans", td.SpanCount()),
zap.Error(err))
return consumererror.NewPermanent(err)
Expand Down
2 changes: 1 addition & 1 deletion exporter/exporterhelper/xexporterhelper/profiles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ func newConsumeProfiles(converter RequestFromProfilesFunc, be *internal.BaseExpo
return func(ctx context.Context, pd pprofile.Profiles) error {
req, err := converter(ctx, pd)
if err != nil {
logger.Error("Failed to convert metrics. Dropping data.",
logger.Error("Failed to convert profiles. Dropping data.",
zap.Int("dropped_samples", pd.SampleCount()),
zap.Error(err))
return consumererror.NewPermanent(err)
Expand Down
Loading