Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes based batching for profiles #12564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for metrics.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

Related PRs:

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 85.49618% with 19 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (da4512d) to head (ddedc5b).

Files with missing lines Patch % Lines
...r/exporterhelper/xexporterhelper/profiles_batch.go 86.59% 11 Missing and 2 partials ⚠️
pdata/pprofile/pb.go 40.00% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (85.49%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12564      +/-   ##
==========================================
- Coverage   91.64%   91.59%   -0.06%     
==========================================
  Files         479      480       +1     
  Lines       26416    26487      +71     
==========================================
+ Hits        24210    24261      +51     
- Misses       1747     1766      +19     
- Partials      459      460       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi requested a review from sfc-gh-sili March 5, 2025 12:53
@iblancasa
Copy link
Contributor Author

@dmitryax @bogdandrutu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants