Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter][batching] Enable batching based on size #12635

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-sili
Copy link
Contributor

Description

This PR enable serialized batching based on size rather than item count.

Link to tracking issue

Fixes #3262

Testing

Documentation

@sfc-gh-sili sfc-gh-sili requested a review from a team as a code owner March 14, 2025 06:31
Copy link

linux-foundation-easycla bot commented Mar 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (9204a06) to head (f05edf8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12635   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files         478      478           
  Lines       26236    26238    +2     
=======================================
+ Hits        24141    24143    +2     
  Misses       1673     1673           
  Partials      422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmacd
Copy link
Contributor

jmacd commented Mar 18, 2025

@bogdandrutu does #12651 cover a fix for that issue? Is the bug described in an issue already?

@sfc-gh-sili
Copy link
Contributor Author

I found yesterday a bug, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/internal/batcher/default_batcher.go#L85 and everywhere where ItemsCount is used in that file.

#12641 addresses this issue. It is built on top of prototype in #12651

@sfc-gh-sili sfc-gh-sili marked this pull request as draft March 19, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processors/batch] Size calculations inconsistent, causing unbounded batch size in bytes
4 participants