-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter][batching] Enable batching based on size #12635
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12635 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 478 478
Lines 26236 26238 +2
=======================================
+ Hits 24141 24143 +2
Misses 1673 1673
Partials 422 422 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found yesterday a bug, see https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/internal/batcher/default_batcher.go#L85 and everywhere where ItemsCount is used in that file.
@bogdandrutu does #12651 cover a fix for that issue? Is the bug described in an issue already? |
#12641 addresses this issue. It is built on top of prototype in #12651 |
Description
This PR enable serialized batching based on size rather than item count.
Link to tracking issue
Fixes #3262
Testing
Documentation