Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] better errors when can't get package name #12682

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

valner
Copy link

@valner valner commented Mar 20, 2025

Description

Make errors more detailed if mdatagen can't get go package name

errors before

Error: failed loading metadata.yaml: exit status 1

after

Error: failed loading metadata.yaml: failed to run go list -f {{.ImportPath}} command: exit status 1: main module (...) does not contain package ...

@valner valner requested review from dmitryax and a team as code owners March 20, 2025 15:29
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.55%. Comparing base (6aad9d1) to head (fd4d73e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/loader.go 80.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12682   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         480      480           
  Lines       26391    26394    +3     
=======================================
+ Hits        24162    24165    +3     
  Misses       1766     1766           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ms-jcorley ms-jcorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valner valner requested a review from ms-jcorley March 21, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants