-
Notifications
You must be signed in to change notification settings - Fork 1.6k
confighttp: Ensure that auth errors use provided error handler #12714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confighttp: Ensure that auth errors use provided error handler #12714
Conversation
…essage from auth extensions is included in the response
I noticed there may be a conflict with an existing PR #12702 , but I wanted to make sure that this issue was brought up before the refactoring, let me know if there are any further changes I need to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @bogdandrutu please take a look.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12714 +/- ##
==========================================
- Coverage 91.43% 91.42% -0.01%
==========================================
Files 487 487
Lines 26808 26811 +3
==========================================
+ Hits 24511 24512 +1
- Misses 1814 1815 +1
- Partials 483 484 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
OTLP/HTTP receiver does not encode authentication errors into a
Status
object, and as such not expose a developer facing error message in theStatus.mesage
field. - https://opentelemetry.io/docs/specs/otlp/#failures-1Resolves this issue by handling authentication errors with the same error handler provided to the Server.
Link to tracking issue
Fixes #12666
Testing
Unit tests for handling errors with and without a server error handler