[chore] exporter/exporterhelper: remove outdated warning #12930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning does not appear to be relevant any more. It comes from a time when the package provided a factory, and I assume it was warning against using that factory directly within the service pipeline, as opposed to indirectly from another exporter.
axw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12930 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 499 499
Lines 27425 27425
=======================================
Hits 25140 25140
Misses 1806 1806
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The warning does not appear to be relevant any more. It comes from a time when the package provided a factory, and I assume it was warning against using that factory directly within the service pipeline, as opposed to indirectly from another exporter.
Link to tracking issue
N/A
Testing
N/A
Documentation
N/A