[cmd/mdatagen] support template datatype #12938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (31.57%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12938 +/- ##
==========================================
- Coverage 91.65% 91.60% -0.05%
==========================================
Files 503 503
Lines 27641 27657 +16
==========================================
+ Hits 25333 25336 +3
- Misses 1822 1835 +13
Partials 486 486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: odubajDT <[email protected]>
odubajDT
commented
Apr 29, 2025
| // NewValueTemplate creates a new Value with the given string value. | ||
| func NewValueTemplate(v string) Value { | ||
| state := internal.StateMutable | ||
| return newValue(&otlpcommon.AnyValue{Value: &otlpcommon.AnyValue_StringValue{StringValue: v}}, &state) |
There was a problem hiding this comment.
@dmitryax maybe question here, should we rather define a full new datatype for the template type, or reuse the string one, since template is not a real-world datatype. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim is to support the new semantic conventions for k8s workloads and generation of code for the template datatype
Link to tracking issue
Fixes #12891
Testing
tested the new functionality on kubeletstatsreceiver here