Skip to content

[ci] Run Go unit tests with GODEBUG=fips140=only #13926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[ci] Run Go unit tests with GODEBUG=fips140=only #13926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e03f91
Add Makefile targets for running unit tests with GODEBUG=fips140=only
ycombinator Oct 3, 2025
8189c3d
Add step to run unit tests with GODEBUG=fips140=only
ycombinator Oct 4, 2025
8825d5e
Remove FIPS-related make targets
ycombinator Oct 4, 2025
23596d3
Skip unit tests that use x509.CreateCertificate when running with GOD…
ycombinator Oct 9, 2025
7d98120
Add make targets for running unit tests with GODEBUG=fips140=only and…
ycombinator Oct 9, 2025
7d2ea7b
Update make target in CI pipeline
ycombinator Oct 9, 2025
063717e
Running make goporto
ycombinator Oct 9, 2025
c4a20ca
Removing non-pipeline changes
ycombinator Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ jobs:
- name: Run Unit Tests
run: |
make -j4 gotest-with-junit
- name: Run Unit Tests with GODEBUG=fips140=only
run: |
make -j4 gotest-fips140-only
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: test-results-${{ runner.os }}-${{ matrix.runner }}-${{ matrix.go-version }}
Expand Down
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ gomoddownload:
gotest:
@$(MAKE) for-all-target TARGET="test"

.PHONY: gotest-fips140-only
gotest-fips140-only:
@$(MAKE) for-all-target TARGET="test-fips140-only"

.PHONY: gobenchmark
gobenchmark:
@$(MAKE) for-all-target TARGET="benchmark"
Expand Down
5 changes: 5 additions & 0 deletions Makefile.Common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ JUNIT_OUT_DIR ?= $(TOOLS_MOD_DIR)/testresults
test:
$(GO_TOOL) gotestsum --packages="./..." -- $(GOTEST_OPT)

.PHONY: test-fips140-only
test-fips140-only:
GODEBUG=tlsmlkem=0 $(GOCMD) mod download
GODEBUG=fips140=only $(GO_TOOL) gotestsum --packages="./..." -- $(GOTEST_OPT) -tags=requirefips

.PHONY: test-with-cover
test-with-cover:
mkdir -p $(PWD)/coverage/unit
Expand Down
Loading