otelcol: remove default telemetry factory #14062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14062 +/- ##
==========================================
+ Coverage 92.45% 92.47% +0.01%
==========================================
Files 660 660
Lines 36218 36218
==========================================
+ Hits 33486 33492 +6
+ Misses 1911 1907 -4
+ Partials 821 819 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just waiting for open-telemetry/opentelemetry-collector-contrib#43718 to be merged now |
axw
force-pushed
the
otelcol-factoriestelemetry-required
branch
from
5747c70 to
1f6461c
Compare
Remove the default telemetry factory, and require callers to specify one, to keep things maintainable.
axw
force-pushed
the
otelcol-factoriestelemetry-required
branch
from
1f6461c to
d46adfd
Compare
mx-psi
approved these changes
Oct 27, 2025
jmacd
approved these changes
Oct 27, 2025
bogdandrutu
reviewed
Oct 27, 2025
Comment on lines
23
to
25
| if factories.Telemetry == nil { | ||
| factories.Telemetry = otelconftelemetry.NewFactory() | ||
| factories.Telemetry = nopTelemetryFactory() | ||
| } |
There was a problem hiding this comment.
Why not really ask users to provide even the no-op?
There was a problem hiding this comment.
i'm ok with setting this as a convenience in otelcoltest
codeboten
approved these changes
Oct 27, 2025
Comment on lines
23
to
25
| if factories.Telemetry == nil { | ||
| factories.Telemetry = otelconftelemetry.NewFactory() | ||
| factories.Telemetry = nopTelemetryFactory() | ||
| } |
There was a problem hiding this comment.
i'm ok with setting this as a convenience in otelcoltest
|
Waiting for the following release is fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the default telemetry factory, and require callers to specify one, to keep things maintainable.
Link to tracking issue
Fixes #14003
Testing
Documentation
N/A