MemoryLimter extension as an http/grpc middleware #14071
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanthzen
changed the title
shivanthzen
force-pushed
the
memorylimiter_middleware
branch
from
d296af7 to
e5b68cf
Compare
shivanthzen
changed the title
|
@shivanthzen Thank you. This looks like a good step forward. Can we add to the memorylimiter extension README.md with an example for use? Would you add a minimal test, at least to be sure that the extension implements the middleware interface? I am not sure what internal support memorylimiter has for testing, but it would be nice to have a small test for the function itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Part of #9591
Testing
Documentation