Introduce switchDictionary methods for profiles
#14075
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is a quite large PR, but there's a lot of repetition in there (which also can't really be reduced). |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (68.26%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14075 +/- ##
==========================================
- Coverage 92.27% 92.14% -0.13%
==========================================
Files 657 662 +5
Lines 41111 41319 +208
==========================================
+ Hits 37936 38075 +139
- Misses 2173 2208 +35
- Partials 1002 1036 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step towards #13106
It introduces private
switchDictionarymethods for all profile structs, so their base dictionary can be switched, which is a requirement (and maybe the biggest bit) of merging profiles.Right now, the private method isn't called yet, because this PR is already very big, and I believe introducing
MergeToshould be in another PR.But the gist is that to merge profiles together, we need to change the base dictionary for the profiles that are being moved before we can merge the two slices of resource profiles into one.