Skip to content

Conversation

@bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (ab33d4b) to head (104ea2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14087      +/-   ##
==========================================
+ Coverage   92.27%   92.29%   +0.02%     
==========================================
  Files         657      657              
  Lines       41100    41100              
==========================================
+ Hits        37926    37935       +9     
+ Misses       2173     2160      -13     
- Partials     1001     1005       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu
Copy link
Member

This is a very large that seems to do more than just add unit tests (it switches proto-go from the slim package to the standard one for one). Should that be split into smaller PRs?

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Oct 28, 2025

it switches proto-go from the slim package to the standard one for one

this is required because the slim version does not have the grpc generated code, so I cannot have e2e tests without it.

EDIT: Also, this is only a test dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants