[fips140][configtls.TestTPM_tpmCertificate_errors] Skip test if GODEBUG=fips140=only is set

[ycombinator]

Description

In #14225, we skipped the configtls.TestTPM_loadCertificate unit test if the tests were run with GODEBUG=fips140=only. Otherwise, the unit test failed with a panic: crypto/cipher: use of CFB is not allowed in FIPS 140-only mode error.

Turns out there was a second unit test in the same package that needed skipping for the same reason: configtls.TestTPM_tpmCertificate_errors. This PR skips it too.

Link to tracking issue

Follow up to #14225

[codspeed-hq]

CodSpeed Performance Report

Merging #14255 will degrade performances by 28.96%

_{Comparing ycombinator:fips-tpm-unit-tests-fix (c9bcee3) with main (2e5bb6d)}

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 3 regressions
✅ 56 untouched
⏩ 20 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	BenchmarkTraceSizeBytes	309 µs	430.9 µs	-28.28%
❌	BenchmarkLogsToProto2k	45 µs	63.3 µs	-28.96%
❌	BenchmarkTracesToProto2k	69 µs	95.8 µs	-27.94%

Footnotes

1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.14%. Comparing base (2e5bb6d) to head (c9bcee3).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14255      +/-   ##
==========================================
- Coverage   92.15%   92.14%   -0.02%     
==========================================
  Files         668      668              
  Lines       41513    41513              
==========================================
- Hits        38257    38251       -6     
- Misses       2219     2223       +4     
- Partials     1037     1039       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dmathieu]

I don't know about this. It silently skips tests, and seeing which test is being skipped could be unclear.
I think it would be clearer (though more verbose) to explicitly skip within eaach test rather than within an helper.

[ycombinator]

I don't know about this. It silently skips tests, and seeing which test is being skipped could be unclear. I think it would be clearer (though more verbose) to explicitly skip within eaach test rather than within an helper.

Makes sense. Updated in d0cff30.

[ycombinator]

Hi @dmathieu @bogdandrutu, the CI failures in this PR seem unrelated to the changes in this PR. I've tried rebasing on the latest main a few times over the past week but that doesn't seem to help. Could you please guide me on how to proceed? Thanks!

[dmathieu]

The failures are due to a breaking change with contrib. They need to be fixed in another PR.