-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add flag to OCB to generate component config JSON schema #14261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (81.32%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14261 +/- ##
==========================================
- Coverage 92.15% 92.01% -0.15%
==========================================
Files 668 672 +4
Lines 41513 42045 +532
==========================================
+ Hits 38257 38687 +430
- Misses 2219 2284 +65
- Partials 1037 1074 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
619c3c0 to
b623fba
Compare
d7ca401 to
00e98ce
Compare
CodSpeed Performance ReportMerging #14261 will not alter performanceComparing
|
7c1157a to
6c0bea6
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
037ae1c to
e9c387f
Compare
Signed-off-by: Pavol Loffay <[email protected]>
|
Food for thought: We could think about capturing the default values of the config through calling the CreateDefaultConfig function and reflecting the values of it. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
This PR adds collector component JSON schema generation to OCB
--generate-schema Experimental: Whether builder should generate JSON schemas for component configs (default false)Example schema generation is here: open-telemetry/opentelemetry-collector-releases#1299
#14288 is alternative solution which adds the schema generation to mdatagen
Link to tracking issue
Fixes #9769
Testing
Documentation