-
Notifications
You must be signed in to change notification settings - Fork 1.9k
service/telemetry: remove otelconftelemetry dependency #14295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14295 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 668 668
Lines 41529 41536 +7
=======================================
+ Hits 38261 38270 +9
+ Misses 2231 2230 -1
+ Partials 1037 1036 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2792266 to
8a26166
Compare
8a26166 to
a5b1bbc
Compare
Merging this PR will not alter performance
|
c65b431 to
65bf460
Compare
65bf460 to
c821cb0
Compare
|
Splitting some changes out into #14308 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
Replace the dependency from service/telemetry's MeterSettings by replacing the DefaultViews field with DefaultDroppedInstruments, which returns a slice of "selectors" given the metrics telemetry level. Selectors are a simplified version of a view selector.
Some other otelconf-related has been refactored:
service.instance.idhas been replaced by a new functional test in internal/e2eLink to tracking issue
Fixes #13809
Testing
Updated tests.
Documentation
N/A