Skip to content

Conversation

@axw
Copy link
Contributor

@axw axw commented Dec 16, 2025

Description

Replace the dependency from service/telemetry's MeterSettings by replacing the DefaultViews field with DefaultDroppedInstruments, which returns a slice of "selectors" given the metrics telemetry level. Selectors are a simplified version of a view selector.

Some other otelconf-related has been refactored:

  • A test in the service package related to service.instance.id has been replaced by a new functional test in internal/e2e
  • otelconf migration code has been moved into otelconftelemetry

Link to tracking issue

Fixes #13809

Testing

Updated tests.

Documentation

N/A

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 96.47059% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.13%. Comparing base (ebcdbd6) to head (c821cb0).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
service/service.go 95.45% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14295   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         668      668           
  Lines       41529    41536    +7     
=======================================
+ Hits        38261    38270    +9     
+ Misses       2231     2230    -1     
+ Partials     1037     1036    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw axw force-pushed the telemetry-defaultdroppedinstruments branch 3 times, most recently from 2792266 to 8a26166 Compare December 17, 2025 03:22
@axw axw changed the title [chore] service/telemetry: remove otelconftelemetry dependency service/telemetry: remove otelconftelemetry dependency Dec 17, 2025
@axw axw force-pushed the telemetry-defaultdroppedinstruments branch from 8a26166 to a5b1bbc Compare December 17, 2025 08:50
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2025

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 56 untouched benchmarks
⏩ 20 skipped benchmarks1


Comparing axw:telemetry-defaultdroppedinstruments (c821cb0) with main (1839ba7)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@axw axw force-pushed the telemetry-defaultdroppedinstruments branch 2 times, most recently from c65b431 to 65bf460 Compare December 17, 2025 09:50
@axw axw force-pushed the telemetry-defaultdroppedinstruments branch from 65bf460 to c821cb0 Compare December 17, 2025 10:01
@axw
Copy link
Contributor Author

axw commented Dec 18, 2025

Splitting some changes out into #14308

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added Stale and removed Stale labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[service/telemetry] remove dependency on otelconf for injecting default views

1 participant