-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support resource detectors for service telemetry #14312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (58.60%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14312 +/- ##
==========================================
- Coverage 92.12% 91.62% -0.51%
==========================================
Files 668 669 +1
Lines 41377 41924 +547
==========================================
+ Hits 38120 38414 +294
- Misses 2222 2436 +214
- Partials 1035 1074 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
CodSpeed Performance ReportMerging this PR will not alter performanceComparing
|
dmathieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does a lot of things. I think it would be better split into smaller chunks.
| include ../../Makefile.Common | ||
|
|
||
| # Override timeout for builder tests | ||
| GOTEST_TIMEOUT=600s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to your PR. Could you move it to another one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that, without this, the tests fails now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like a problem we want to fix rather than walk around. Especially as a 10 minutes timeout is very long.
Signed-off-by: Israel Blancas <[email protected]>
Let me see what I can do. |
Description
Support resource detectors for service telemetry using Go SDK.
Link to tracking issue
Fixes #14311