Skip to content

Conversation

@iblancasa
Copy link
Contributor

Description

Support resource detectors for service telemetry using Go SDK.

Link to tracking issue

Fixes #14311

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 58.60870% with 238 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (ff135af) to head (f66cd1e).

Files with missing lines Patch % Lines
service/internal/resource/config.go 59.09% 149 Missing and 31 partials ⚠️
service/telemetry/otelconftelemetry/sdk.go 21.05% 29 Missing and 1 partial ⚠️
service/telemetry/otelconftelemetry/resource.go 29.41% 24 Missing ⚠️
service/internal/resource/detectors.go 93.65% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (58.60%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14312      +/-   ##
==========================================
- Coverage   92.12%   91.62%   -0.51%     
==========================================
  Files         668      669       +1     
  Lines       41377    41924     +547     
==========================================
+ Hits        38120    38414     +294     
- Misses       2222     2436     +214     
- Partials     1035     1074      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iblancasa iblancasa marked this pull request as draft December 19, 2025 19:06
@iblancasa iblancasa marked this pull request as ready for review December 23, 2025 09:05
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2025

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing iblancasa:14311 (f66cd1e) with main (ff135af)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 59 untouched benchmarks
⏩ 20 skipped benchmarks1

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does a lot of things. I think it would be better split into smaller chunks.

include ../../Makefile.Common

# Override timeout for builder tests
GOTEST_TIMEOUT=600s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to your PR. Could you move it to another one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that, without this, the tests fails now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a problem we want to fix rather than walk around. Especially as a 10 minutes timeout is very long.

Signed-off-by: Israel Blancas <[email protected]>
@iblancasa
Copy link
Contributor Author

This PR does a lot of things. I think it would be better split into smaller chunks.

Let me see what I can do.

@iblancasa iblancasa marked this pull request as draft January 7, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support resource detectors for service telemetry

2 participants