-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[ci] Add capability to rerun failed action on PR using /rerun comment #14314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Paulo Dias <[email protected]>
|
You mention that only PR authors can do this rerun (which makes sense). I'm not seeing any check that the person writing the comment is indeed the PR author though. How is that enforced? Do you know what happens if an author sends |
CodSpeed Performance ReportMerging #14314 will not alter performanceComparing
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14314 +/- ##
==========================================
- Coverage 92.11% 92.09% -0.02%
==========================================
Files 668 668
Lines 41363 41363
==========================================
- Hits 38100 38092 -8
- Misses 2226 2231 +5
- Partials 1037 1040 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Paulo Dias <[email protected]>
…ector into ci/_rerun Signed-off-by: Paulo Dias <[email protected]>
Thanks for the review @dmathieu! Good catch, I added that filter now. I will port it to the contrib side as I agree it makes sense.
Will do nothing, since the script is filtering by the failing ones only, as you can see in the following line |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description As discussed on the [core side](open-telemetry/opentelemetry-collector#14314 (comment)), it is safer to allow only PR authors to use the `/rerun` command. This does not change the feature, only filters by who can execute it in each PR. Signed-off-by: Paulo Dias <[email protected]>
Description
This PR enables contributors to re-trigger failed jobs by using the /rerun comment in the PRs.
The same was done in the contrib side, and I think it is valuable to port it to the core side.
Documentation
Updated the CONTRIBUTING.md with this reference.