Skip to content

Conversation

@paulojmdias
Copy link
Member

@paulojmdias paulojmdias commented Dec 18, 2025

Description

This PR enables contributors to re-trigger failed jobs by using the /rerun comment in the PRs.

The same was done in the contrib side, and I think it is valuable to port it to the core side.

Documentation

Updated the CONTRIBUTING.md with this reference.

@paulojmdias paulojmdias requested a review from a team as a code owner December 18, 2025 13:33
@paulojmdias paulojmdias requested a review from jmacd December 18, 2025 13:33
@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 18, 2025
@dmathieu
Copy link
Member

You mention that only PR authors can do this rerun (which makes sense). I'm not seeing any check that the person writing the comment is indeed the PR author though. How is that enforced?

Do you know what happens if an author sends /rerun in a PR for which the actions haven't been approved yet (first time contributors need a manual action from a triager+ to run their action)?

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #14314 will not alter performance

Comparing paulojmdias:ci/_rerun (696cd96) with main (4ce4e37)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 59 untouched
⏩ 20 skipped1

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.09%. Comparing base (4ce4e37) to head (696cd96).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14314      +/-   ##
==========================================
- Coverage   92.11%   92.09%   -0.02%     
==========================================
  Files         668      668              
  Lines       41363    41363              
==========================================
- Hits        38100    38092       -8     
- Misses       2226     2231       +5     
- Partials     1037     1040       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulojmdias
Copy link
Member Author

You mention that only PR authors can do this rerun (which makes sense). I'm not seeing any check that the person writing the comment is indeed the PR author though. How is that enforced?

Thanks for the review @dmathieu! Good catch, I added that filter now. I will port it to the contrib side as I agree it makes sense.

Do you know what happens if an author sends /rerun in a PR for which the actions haven't been approved yet (first time contributors need a manual action from a triager+ to run their action)?

Will do nothing, since the script is filtering by the failing ones only, as you can see in the following line

songy23 pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Dec 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

As discussed on the [core
side](open-telemetry/opentelemetry-collector#14314 (comment)),
it is safer to allow only PR authors to use the `/rerun` command.

This does not change the feature, only filters by who can execute it in
each PR.

Signed-off-by: Paulo Dias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants