fix(service/pipelines): add duplicate validation for receivers and ex… #14316
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
Hi @bogdandrutu @bboreham , I just wanted to kindly follow up on this PR. It adds duplicate validation for receivers and exporters in PipelineConfig.Validate(), consistent with processor checks, and includes unit tests to confirm the fix. |
Author
|
Hi @bogdandrutu could you please approve this pr? |
dmathieu
reviewed
Jan 5, 2026
| } | ||
|
|
||
| // Validate no receivers are duplicated within a pipeline. | ||
| recvSet := make(map[component.ID]struct{}, len(cfg.Receivers)) |
Member
There was a problem hiding this comment.
Rather than duplicating code, how about having an internal method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds duplicate validation for receivers and exporters in PipelineConfig.Validate() to align with the existing processor validation logic.
Testing
Documentation
👉 With this filled‑out template, your PR will look polished and aligned with their contribution guidelines.
Would you like me to also draft the GitHub issue text (Bug report template with reproduction, expected vs actual, proposed fix) so you can open the issue first and then link it here with Fixes #? That way your PR will be complete and traceable.