Add metric level registry for components #14338
Conversation
iblancasa
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
…metry levels for their metrics Signed-off-by: Israel Blancas <[email protected]>
iblancasa
requested review from
andrzej-stencel,
dmathieu,
evan-bradley and
mx-psi
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14338 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 668 673 +5
Lines 41529 41574 +45
=======================================
+ Hits 38263 38305 +42
- Misses 2230 2231 +1
- Partials 1036 1038 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // a given meter or instrument. Components can register these declarations so | ||
| // the service can derive default views that drop metrics when the level is | ||
| // below the configured threshold. | ||
| type MetricLevelConfig struct { |
There was a problem hiding this comment.
Should we allow components to register views instead?
There was a problem hiding this comment.
Maybe. I'm not against that. I was thinking about keeping this because maybe want to do something based on the stability metric level? Something we can add later. But I'm ok with the change. Let me know what do you think and I will be more than happy to change this.
There was a problem hiding this comment.
I haven't reviewed the rest of this PR but I think this should be on an xcomponent package instead of here since this would (at the beginning at least) an experimental package (there's also spec work about this, see open-telemetry/opentelemetry-specification/issues/4391)
There was a problem hiding this comment.
I'm ok with that. Will implement the change.
3 participants
Description
Created a registry, similar to the feature gates, for the component metrics.
Link to tracking issue
Fixes #11754