Update pdata comments #14342
Open
Update pdata comments #14342
+34
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When service.telemetry.metrics.level is set to 'none', the collector should skip registering process metrics to avoid errors on platforms where gopsutil is not supported (such as AIX). This change conditionally registers process metrics only when the metrics level is not LevelNone, preventing the 'failed to register process metrics: not implemented yet' error on unsupported platforms. Fixes regression introduced in v0.136.0 where the check for metrics level was removed.
Similar to the resolution for pcommon.Value in previous changes, this update ensures consistent documentation across all pdata types by clarifying that calling functions on zero-initialized instances is invalid usage. Changes: - Updated template files (one_of_field.go, one_of_message_value.go) to generate improved comment wording - Updated pcommon/value.go comments manually - Updated all generated pdata files to use consistent wording: 'is invalid and will cause a panic' instead of 'will cause a panic' This makes it clearer that using zero-initialized instances is not just dangerous but explicitly invalid usage, improving API documentation clarity.
Arunodoy18
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
bogdandrutu
approved these changes
Jan 1, 2026
Member
|
@Arunodoy18 please address the CI failures |
dmathieu
approved these changes
Jan 5, 2026
codeboten
requested changes
Jan 5, 2026
| if err := proctelemetry.RegisterProcessMetrics(srv.telemetrySettings); err != nil { | ||
| return nil, fmt.Errorf("failed to register process metrics: %w", err) | ||
| // Only register process metrics if metrics telemetry is enabled | ||
| if telemetryCfg, ok := cfg.Telemetry.(*otelconftelemetry.Config); !ok || telemetryCfg.Metrics.Level != configtelemetry.LevelNone { |
Contributor
There was a problem hiding this comment.
this change is unrelated to the comment change, please remove this from the pr and we can get this merged
Author
There was a problem hiding this comment.
Yeah sure , Doing this .
Thank you
Author
There was a problem hiding this comment.
Hey, Things are been removed , You can Now check for the unrelated changes for merging.
Thank you
Arunodoy18
added a commit
to Arunodoy18/opentelemetry-collector
that referenced
this pull request
Jan 6, 2026
…cenarios This enhancement adds a connection_pool_size configuration option to the OTLP exporter, enabling multiple gRPC connections with round-robin load balancing. Key changes: - Add connection_pool_size config parameter (default: 0, uses 1 connection) - Implement round-robin load balancing across multiple connections - Support for 1-256 concurrent gRPC connections - Backward compatible: default behavior unchanged This resolves performance issues in high-throughput environments (10K+ spans/sec) and high-latency network scenarios where a single gRPC connection becomes a bottleneck. Also fixes unrelated service.go issue per contributor feedback on PR open-telemetry#14342.
Author
|
Can anyone guide me with the Failures. |
Member
|
You need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates documentation comments across the pdata package to provide consistent and clearer messaging about invalid usage of zero-initialized instances, similar to what was done for pcommon.Value in previous changes.
Changes
Before vs After
Before: