Skip to content

fix: Remove remaining default configuration. #14351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tank-500m wants to merge 8 commits into
base: main
Choose a base branch
from
+22 −1
Open

fix: Remove remaining default configuration. #14351

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71f0a03
fix: Remove the empty balancer_name
tank-500m Jan 5, 2026
add1b82
test: verify default balancer
tank-500m Jan 5, 2026
2fb7a87
Add changelog
tank-500m Jan 6, 2026
b9bd07d
Merge branch 'main' into fix-otlp-default-balancer
tank-500m Jan 6, 2026
bfe00b2
Merge branch 'main' into fix-otlp-default-balancer
tank-500m Jan 7, 2026
a9f23d6
test: set default balanceer
tank-500m Jan 9, 2026
deb26d2
Merge remote-tracking branch 'origin/fix-otlp-default-balancer' into …
tank-500m Jan 9, 2026
5ee66e5
Merge branch 'main' into fix-otlp-default-balancer
tank-500m Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion exporter/otlpexporter/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ func createDefaultConfig() component.Config {
clientCfg.WriteBufferSize = 512 * 1024
// For backward compatibility:
clientCfg.Keepalive = configoptional.None[configgrpc.KeepaliveClientConfig]()
clientCfg.BalancerName = ""

return &Config{
TimeoutConfig: exporterhelper.NewDefaultTimeoutConfig(),
Expand Down
1 change: 1 addition & 0 deletions exporter/otlpexporter/factory_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func TestCreateDefaultConfig(t *testing.T) {
assert.Equal(t, configoptional.Some(exporterhelper.NewDefaultQueueConfig()), ocfg.QueueConfig)
assert.Equal(t, exporterhelper.NewDefaultTimeoutConfig(), ocfg.TimeoutConfig)
assert.Equal(t, configcompression.TypeGzip, ocfg.ClientConfig.Compression)
assert.Equal(t, configgrpc.BalancerName(), ocfg.ClientConfig.BalancerName)
}

func TestCreateMetrics(t *testing.T) {
Expand Down
Loading