Fix env var endpoint override #14353
Open
+195
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When service.telemetry.metrics.level is set to 'none', the collector should skip registering process metrics to avoid errors on platforms where gopsutil is not supported (such as AIX). This change conditionally registers process metrics only when the metrics level is not LevelNone, preventing the 'failed to register process metrics: not implemented yet' error on unsupported platforms. Fixes regression introduced in v0.136.0 where the check for metrics level was removed.
Similar to the resolution for pcommon.Value in previous changes, this update ensures consistent documentation across all pdata types by clarifying that calling functions on zero-initialized instances is invalid usage. Changes: - Updated template files (one_of_field.go, one_of_message_value.go) to generate improved comment wording - Updated pcommon/value.go comments manually - Updated all generated pdata files to use consistent wording: 'is invalid and will cause a panic' instead of 'will cause a panic' This makes it clearer that using zero-initialized instances is not just dangerous but explicitly invalid usage, improving API documentation clarity.
…onfig file endpoints Fixes open-telemetry#14286 When both OTEL_EXPORTER_OTLP_TRACES_ENDPOINT environment variable and a configured endpoint in the config file are present, the URL scheme from the environment variable was incorrectly overriding the scheme from the config file, resulting in mixed endpoints (e.g., http scheme from env var + path from config file). This fix ensures that environment variables do not override explicitly configured endpoints by temporarily unsetting the OTEL_EXPORTER_OTLP_*_ENDPOINT environment variables before creating the SDK, then restoring them afterward. According to the OpenTelemetry specification, explicit configuration should take precedence over environment variables. Changes: - Modified sdk.go to temporarily unset OTEL_EXPORTER_OTLP_*_ENDPOINT environment variables before calling config.NewSDK() - Added helper functions unsetOTLPEndpointEnvVars() and restoreEnvVars() - Added comprehensive tests to verify env vars don't override config
Arunodoy18
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14286
Description
When both
OTEL_EXPORTER_OTLP_TRACES_ENDPOINTenvironment variable and a configured endpoint in the config file are present, the URL scheme from the environment variable was incorrectly overriding the scheme from the config file, resulting in mixed endpoints.This fix ensures that environment variables do not override explicitly configured endpoints by temporarily unsetting the
OTEL_EXPORTER_OTLP_*_ENDPOINTenvironment variables before creating the SDK, then restoring them afterward.According to the OpenTelemetry specification, explicit configuration should take precedence over environment variables.
Changes
Testing
All existing tests pass, and new tests verify the fix works correctly.