Skip to content

Conversation

@florianl
Copy link
Member

Description

Add AddProfilesScraper similar to scraperhelper.AddScraper

Link to tracking issue

Fixes #

Testing

Documentation

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested a review from a team as a code owner January 14, 2026 15:32
@florianl florianl requested a review from jmacd January 14, 2026 15:32
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.84%. Comparing base (17646a7) to head (6978e72).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14427      +/-   ##
==========================================
- Coverage   91.85%   91.84%   -0.02%     
==========================================
  Files         677      677              
  Lines       42680    42686       +6     
==========================================
  Hits        39203    39203              
- Misses       2423     2427       +4     
- Partials     1054     1056       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1


Comparing florianl:xscraperhelper-AddProfilesScraper (6978e72) with main (17646a7)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2026
…14428)

This is meant to go alongside
#14427
If we will have `AddProfilesScraper`, using `AddMetricsScraper` makes
more sense than the slightly obscure `AddScraper`.

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 21, 2026
@florianl
Copy link
Member Author

@open-telemetry/collector-approvers friendly ping for feedback

@mx-psi mx-psi added this pull request to the merge queue Jan 26, 2026
Merged via the queue into open-telemetry:main with commit 3ac3dd7 Jan 26, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants