-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Handle profiles in generated component tests #14434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Handle profiles in generated component tests #14434
Conversation
e9bbbf2 to
19fe118
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14434 +/- ##
==========================================
- Coverage 91.85% 91.84% -0.01%
==========================================
Files 677 677
Lines 42680 42692 +12
==========================================
+ Hits 39203 39212 +9
- Misses 2423 2425 +2
- Partials 1054 1055 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Contrib tests seem to be failing because they will need to run |
c0ff5de to
058c5cc
Compare
|
Ping for review? |
We currently don't test profiles in mdatagen code generation.
That's not really an issue so far, as we only have components that support other signals as well.
But with open-telemetry/opentelemetry-ebpf-profiler#1075, we try to import
consumertestand never use it.