Skip to content

Conversation

@dmathieu
Copy link
Member

We currently don't test profiles in mdatagen code generation.
That's not really an issue so far, as we only have components that support other signals as well.

But with open-telemetry/opentelemetry-ebpf-profiler#1075, we try to import consumertest and never use it.

@dmathieu dmathieu force-pushed the profiles-generated-component-test branch from e9bbbf2 to 19fe118 Compare January 15, 2026 15:30
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing dmathieu:profiles-generated-component-test (5c37774) with main (17646a7)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.84%. Comparing base (17646a7) to head (5c37774).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14434      +/-   ##
==========================================
- Coverage   91.85%   91.84%   -0.01%     
==========================================
  Files         677      677              
  Lines       42680    42692      +12     
==========================================
+ Hits        39203    39212       +9     
- Misses       2423     2425       +2     
- Partials     1054     1055       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu
Copy link
Member Author

Contrib tests seem to be failing because they will need to run go mod tidy.

@dmathieu dmathieu marked this pull request as ready for review January 15, 2026 16:23
@dmathieu dmathieu requested review from a team, dmitryax and evan-bradley as code owners January 15, 2026 16:23
@dmathieu dmathieu force-pushed the profiles-generated-component-test branch from c0ff5de to 058c5cc Compare January 22, 2026 09:00
@dmathieu
Copy link
Member Author

Ping for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants