Skip to content

Avoid duplicate Cobra CLI error output in generated commands #14436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsevr wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Avoid duplicate Cobra CLI error output in generated commands #14436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da9fd91
Avoid duplicate Cobra CLI error output in generated commands
dsevr Jan 16, 2026
ab0972c
changelog: fix duplicate CLI error output
dsevr Jan 19, 2026
78673d1
changelog: split CLI error fix into builder and mdatagen
dsevr Jan 19, 2026
0115a95
changelog: fix component to cmd and clarify builder/mdatagen
dsevr Jan 21, 2026
6e48866
changelog: fix components for builder and mdatagen CLI error output
dsevr Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .chloggen/cobra-cli-error-builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
change_type: bug_fix
component: cmd/builder
note: Fix duplicate error output when CLI command execution fails in the builder tool.
issues: [14436]
4 changes: 4 additions & 0 deletions .chloggen/cobra-cli-error-mdatagen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
change_type: bug_fix
component: cmd/mdatagen
note: Fix duplicate error output when CLI command execution fails in the mdatagen tool.
issues: [14436]
7 changes: 6 additions & 1 deletion cmd/builder/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
package main

import (
"os"

"github.com/spf13/cobra"

"go.opentelemetry.io/collector/cmd/builder/internal"
Expand All @@ -12,5 +14,8 @@ import (
func main() {
cmd, err := internal.Command()
cobra.CheckErr(err)
cobra.CheckErr(cmd.Execute())

if err := cmd.Execute(); err != nil {
os.Exit(1)
}
}
7 changes: 6 additions & 1 deletion cmd/mdatagen/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ package main
//go:generate mdatagen metadata.yaml

import (
"os"

"github.com/spf13/cobra"

"go.opentelemetry.io/collector/cmd/mdatagen/internal"
Expand All @@ -14,5 +16,8 @@ import (
func main() {
cmd, err := internal.NewCommand()
cobra.CheckErr(err)
cobra.CheckErr(cmd.Execute())

if err := cmd.Execute(); err != nil {
os.Exit(1)
}
}
Loading