[mdatagen] bug fix - reaggreagate_set test generation #14441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes reaggregation test generation when metrics have attributes with
requirement_level: required.testdata/config.yamlincludedattributes: []in thereaggregate_setsection, but required attributes must always be present. This caused config validation to fail with an error like:Fix: Updated
config.yaml.tmplto userequiredAttributeshelper to include required attributes in thereaggregate_setconfig instead of an empty array.metrics_test.goused different values for required attributes across data points, preventing them from merging during reaggregation. The test expected 1 data point but received 2.Fix - Updated
metrics_test.go.tmplto use the same value for required attributes across both data points in reaggregation tests, allowing them to merge correctly while still testing that non-required attributes are dropped.Link to tracking issue
Fixes #
Testing
required_string_attrattribute andreaggregate.metric.with_requiredmetric tosamplereceiver/metadata.yamlto cover this scenario