-
Notifications
You must be signed in to change notification settings - Fork 1.9k
mdatagen: add metric validation test coverage #14467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
mdatagen: add metric validation test coverage #14467
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14467 +/- ##
==========================================
- Coverage 91.85% 91.84% -0.02%
==========================================
Files 677 677
Lines 42680 42686 +6
==========================================
+ Hits 39205 39206 +1
- Misses 2422 2425 +3
- Partials 1053 1055 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
|
This PR adds test coverage for metric validation logic in mdatagen, including checks for invalid or incomplete metric definitions and semantic convention URLs.
Follow-up to the stability-focused PR(#14408) to keep test concerns separated.