Skip to content

Conversation

@Syedowais312
Copy link
Contributor

This PR adds test coverage for metric validation logic in mdatagen, including checks for invalid or incomplete metric definitions and semantic convention URLs.

Follow-up to the stability-focused PR(#14408) to keep test concerns separated.

@Syedowais312 Syedowais312 requested review from a team and dmitryax as code owners January 22, 2026 18:59
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.84%. Comparing base (d471f6d) to head (e8ac564).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14467      +/-   ##
==========================================
- Coverage   91.85%   91.84%   -0.02%     
==========================================
  Files         677      677              
  Lines       42680    42686       +6     
==========================================
+ Hits        39205    39206       +1     
- Misses       2422     2425       +3     
- Partials     1053     1055       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 61 untouched benchmarks
⏩ 20 skipped benchmarks1


Comparing Syedowais312:test/mdatagen-metric-validation-v2 (e8ac564) with main (3ac3dd7)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 23, 2026
@Syedowais312 Syedowais312 requested a review from dmathieu January 24, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd/mdatagen Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants