Skip to content

Clarify pattern matching is case-sensitive#556

Open
trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask:spec-pattern-matching-case-sensitive
Open

Clarify pattern matching is case-sensitive#556
trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask:spec-pattern-matching-case-sensitive

Conversation

@trask
Copy link
Member

@trask trask commented Mar 4, 2026

@trask trask marked this pull request as ready for review March 4, 2026 21:09
@trask trask requested a review from a team as a code owner March 4, 2026 21:09
@SylvainJuge
Copy link

To me, what I described in open-telemetry/opentelemetry-java#8137 is an inconsistency, which may come from the lack of a clear specification in this repository.

What should be done is either:

This PR documents the current state and thus addresses (2), which would make the Java implementation aligned with the spec short term.

However, I think we should try to fix the underlying issue with (1) by removing ambiguity in the spec and settle on a consistent way to deal with case-sensitivity.

@trask
Copy link
Member Author

trask commented Mar 5, 2026

What should be done is either:

This PR documents the current state and thus addresses (2), which would make the Java implementation aligned with the spec short term.

However, I think we should try to fix the underlying issue with (1) by removing ambiguity in the spec and settle on a consistent way to deal with case-sensitivity.

@SylvainJuge I'm probably missing something, I thought this PR is fixing the specification to make the case-sensitivity explicit?

@SylvainJuge
Copy link

My bad, I completely mis-read the diff here, sorry for the noise.

I thought it only applied to "wildcard matching" whereas it also applies to the "exact match", so this aligns on having everything case-sensitive.

Copy link
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — making case-sensitivity explicit is the right call. Consistent with how wildcards already behave, and SylvainJuge's concern is resolved in the comments.

@jack-berg
Copy link
Member

Any comments on this @open-telemetry/configuration-approvers? Given other conversations about case sensitivity in JSON schema (like this conversation where we made a decision to make enum values lower_snake_case because JSON schema doesn't support case insensitive enums), I think we should adopt a stance of "case sensitivity is assumed unless explicitly stated otherwise".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants