POC: Possible implementation of opentelemetry-cpp-contrib cmake project with components #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for adding a top level CMakeLists.txt file to this repo in order to create a versioned
opentelemetry-cpp-contrib
package with components.Goals:
opentelemetry-cpp-contrib
package that depends onopentelmetry-cpp
opentelemetry-cpp
dependency:find_package
to import an installedopentelemetry-cpp
packageopentelemetry-cpp
from the git repo (or git submodule) and build it together withopentelemetry-cpp-contrib
in a single build treefind_package(opentelemetry-cpp-contrib COMPONENTS exporters_geneva_metrics)
This requires some minor changes to the
opentelemetry-cpp
cmake install functions for general use included in this branch.open-telemetry/opentelemetry-cpp@main...dbarker:opentelemetry-cpp:poc_otel_cmake_external_repo_support
Posting here for discussion.