[Geneva] Update opentelemetry-cpp to 1.21.0 #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
reviewed
Jun 10, 2025
|
@dbarker FYI, this adopts the |
lalitb
approved these changes
Jun 10, 2025
dbarker
reviewed
Jun 10, 2025
| FILES_MATCHING | ||
| PATTERN "*.h") | ||
| else() | ||
| set_target_properties( |
There was a problem hiding this comment.
In a future PR these target properties can be moved to above the MAIN_PROJECT conditional so the export name of the targets is the same for both cases.
There was a problem hiding this comment.
Addressed it in the new PR below.
There was a problem hiding this comment.
Thanks. I've added some comments. These export name properties are good to set unconditionally after add_library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.