Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.EntityFrameworkCore] Fix db.system for Devart packages #2571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Feb 18, 2025

Follow up to ##2465

Changes

[Instrumentation.EntityFrameworkCore] Fix db.system for Devart packages.

Checked with old packages. Historically, the name of nuget package was used, instead of actual library name.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore label Feb 18, 2025
@Kielek Kielek marked this pull request as ready for review February 18, 2025 09:58
@Kielek Kielek requested a review from a team as a code owner February 18, 2025 09:58
@Kielek
Copy link
Contributor Author

Kielek commented Feb 18, 2025

@vladajankovic, you might be interested in this PR.

@vladajankovic
Copy link
Contributor

@Kielek Thats awesome. I had a suspicion that the other databases that use Devart library have the same issue. Glad this is getting a fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants