[WCF] Avoid creating activity - #5124
Open
martincostello wants to merge 1 commit into
Open
Conversation
Avoid creating an activity and associated tags if there are no trace listeners configured for the activity source.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5124 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 484 484
Lines 20555 20559 +4
=======================================
+ Hits 16071 16075 +4
Misses 4484 4484
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes WCF tracing by skipping activity tag construction when the selected activity source has no listeners.
Changes:
- Adds listener checks for incoming server requests.
- Adds listener checks for outgoing client requests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
TelemetryDispatchMessageInspector.cs |
Adds the incoming-request fast path. |
ClientChannelInstrumentation.cs |
Adds the outgoing-request fast path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
martincostello
marked this pull request as ready for review
August 25, 2026 16:21
martincostello
enabled auto-merge
August 25, 2026 16:21
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-26 19:56 UTC Review the latest changes. Status above doesn't look right?
|
matt-hensley
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Avoid creating an activity and associated tags if there are no trace listeners configured for the activity source.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)