Conversation
# Conflicts: # src/OpenTelemetry.AutoInstrumentation/Configurations/GeneralSettings.cs
Kielek
left a comment
There was a problem hiding this comment.
I have 2 concerns here
- New transitive dependencies.
Google.Protobufwas already removed from the distribution in scope of update od OTel ADK to 1.11.0: 3986System.Collections.Immutable- Do you any possibility to drop this dependency in Opam.Client package?
- Lack of integration tests with OpAmp server. I see 2 options here
- create mocked server as we have for OTLP protocol
- Utilize some existing dockerized server.
Adding this kind of tests can be done as follow up PR.
I was looking what OpenTelemetry.Exporter.OpenTelemetryProtocol was doing. This experience could be transferred to OpAMP client as well.
Probably not. This may have to stay.
I could reuse OpAMP Go's example server. |
ysolomchenko
left a comment
There was a problem hiding this comment.
I believe it makes sense to create separate settings for OpAMP and handle calculations there (ConnectionType and ServerUrl). This would allow us :
- Keep code consistency
- Add file-based configuration
Yes, this seems good change for this PR even. |
|
Moving to draft. The plan is to implement the next version without deps. |
# Conflicts: # docs/file-based-configuration.md # src/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Assemblies.NetFramework/Directory.Packages.props # src/OpenTelemetry.AutoInstrumentation.Native/netfx_assembly_redirection.h # src/OpenTelemetry.AutoInstrumentation/Configurations/FileBasedConfiguration/YamlConfiguration.cs # src/OpenTelemetry.AutoInstrumentation/Instrumentation.cs # test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-arm64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-x64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_linux-arm64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_linux-x64.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_osx.verified.txt # test/IntegrationTests/BuildTests.DistributionStructure_windows.verified.txt
|
Blocked at the moment by: #4783 |
What
Adds experimental opamp client.
More info in contrib repo:
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.OpAmp.Client
Tests
Build was locally tested.
Additional tools are unit tested.
Checklist
CHANGELOG.mdis updated.