Enable Roslyn analysis - main project - part III#4704
Merged
Kielek merged 13 commits intoopen-telemetry:mainfrom Dec 12, 2025
Merged
Enable Roslyn analysis - main project - part III#4704Kielek merged 13 commits intoopen-telemetry:mainfrom
Kielek merged 13 commits intoopen-telemetry:mainfrom
Conversation
nrcventura
approved these changes
Dec 11, 2025
Member
nrcventura
left a comment
nrcventura
left a comment
There was a problem hiding this comment.
These changes look good, but we should think about if there is a better way to handle the exception analysis.
We have a lot of areas where we need to disable CA1031 (the general exception handling), and I'm wondering if there are any cases in this project where we should just focus on specific exception types. Because this project should not cause harm to the application, I feel like more often than not, we need to catch all exceptions, and not just specific ones. So maybe we should suppress that analysis at the project level.
Kielek
force-pushed
the
analysis-mainproject
branch
from
b7aa13b to
a925d81
Compare
Member
Author
|
@nrcventura, CA1031 muted on the project level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why & What
Enable Roslyn analysis (
<AnalysisLevel>latest-All</AnalysisLevel>) - main project - part III.This PR is big enough for review. There will be 1+ related to this stuff.
Worth to consider reviewing commit by commit.
Tests
CI
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.[ ] New features are covered by tests.