Enable Roslyn analysis - others - part 1#4741
Merged
Kielek merged 2 commits intoopen-telemetry:mainfrom Jan 12, 2026
Merged
Conversation
RassK
reviewed
Jan 9, 2026
| { | ||
| Environment.SetEnvironmentVariable(ConfigurationKeys.Logs.LogsInstrumentationEnabled, null); | ||
| #if NET | ||
| foreach (var logInstrumentation in Enum.GetValues<LogInstrumentation>()) |
Contributor
There was a problem hiding this comment.
nit: to me it seems that a polyfill (of Enum.GetValues<TEnum>()) could be cleaner.
Member
Author
There was a problem hiding this comment.
I agree, but I do not found the good way to create the polyfils without bumping to LangVersion 14.0.
It cannot be done due to some builds.
extension keyword is new feature in .NET10 SDK
Member
Author
There was a problem hiding this comment.
RassK
approved these changes
Jan 9, 2026
Contributor
RassK
left a comment
RassK
left a comment
There was a problem hiding this comment.
Just one nit to clean code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why & What
Enable Roslyn analysis (
<AnalysisLevel>latest-All</AnalysisLevel>) - others - part 1Trying to move
<AnalysisLevel>latest-All</AnalysisLevel>to Common.props.In this PR - non controversial changes only.
Tests
CI
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.[ ] New features are covered by tests.