Merged
Conversation
Member
Author
|
validate-documentation should be fixed by #4851 |
ysolomchenko
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades spdlog from version 1.14.1 to 1.15.3 to address CVE-2025-6140 (a security vulnerability). The upgrade includes enabling UTF-8 support on Windows by adding the /utf-8 compiler flag to all build configurations. The PR does not upgrade to versions 1.16.0 or 1.17.0 due to compilation warnings.
Changes:
- Updated spdlog version from 1.14.1 to 1.15.3
- Added
/utf-8compiler flag to all Windows build configurations (Debug/Release, x86/x64) for both static library and DLL projects, as well as test projects - Updated bundled fmt library to match spdlog 1.15.3 requirements
Reviewed changes
Copilot reviewed 53 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/internal/native-dependencies.md | Updated documentation to reflect spdlog version 1.15.3 |
| src/OpenTelemetry.AutoInstrumentation.Native/lib/spdlog/include/spdlog/version.h | Bumped version constants to 1.15.3 |
| src/OpenTelemetry.AutoInstrumentation.Native/OpenTelemetry.AutoInstrumentation.Native.vcxproj | Added /utf-8 compiler flag to all build configurations for static library |
| src/OpenTelemetry.AutoInstrumentation.Native/OpenTelemetry.AutoInstrumentation.Native.DLL.vcxproj | Added /utf-8 compiler flag to all build configurations for DLL |
| test/OpenTelemetry.AutoInstrumentation.Native.Tests/OpenTelemetry.AutoInstrumentation.Native.Tests.vcxproj | Added /utf-8 compiler flag to all build configurations for tests |
| src/OpenTelemetry.AutoInstrumentation.Native/lib/spdlog/include/spdlog/* | Updated spdlog library headers to version 1.15.3 including async logger flush behavior, registry API, and OS utilities |
| src/OpenTelemetry.AutoInstrumentation.Native/lib/spdlog/include/spdlog/fmt/bundled/* | Updated bundled fmt library to match spdlog 1.15.3 requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nrcventura
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
https://nvd.nist.gov/vuln/detail/CVE-2025-6140
What
Bump spdlog to 1.15.3
utf-8 support needs to be enabled on Windows.
Further updates (1.16.0/1.17.0) leads to
Tests
CI
Checklist
[ ]CHANGELOG.mdis updated.Newfeatures are covered by tests.