-
Notifications
You must be signed in to change notification settings - Fork 870
Add support for KVList values in TagWriter #6812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6812 +/- ##
==========================================
- Coverage 86.88% 86.88% -0.01%
==========================================
Files 262 262
Lines 12350 12349 -1
==========================================
- Hits 10730 10729 -1
Misses 1620 1620
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks for the contribution! This PR modifies the attribute serialization hot path ( What's the motivation? I don't see a linked issue. I'd recommend creating an issue first to drive clarity on:
This will help us align on whether this is the right approach before investing more time in the implementation. |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes