Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Jan 21, 2026

Fixes #6840
The comments.login is otelbot-dotnet instead of app/otelbot-dotnet

Changes

Problem

The release automation was failing with the error Could not find package push comment on pr when running the /PushPackages command on PR #6839.

Root cause: The GitHub API returns different author.login values for GitHub Apps depending on context:

  • PR author: app/otelbot-dotnet (includes app/ prefix)
  • Comment author: otelbot-dotnet (no prefix)

The scripts were using the same variable (expectedPrAuthorUserName) to match both PR authors and comment authors, causing the comment author check to fail.

Solution

Introduced a separate parameter expectedCommentAuthorUserName to correctly match comment authors.

Changes

New GitHub variable required:

  • AUTOMATION_APPLICATION_LOGIN = otelbot-dotnet

Files modified:

File Change
.github/workflows/automation.yml Added application-login output
.github/workflows/publish-packages-1.0.yml Pass expectedCommentAuthorUserName to TryPostPackagesReadyNoticeOnPrepareReleasePullRequest
.github/workflows/post-release.yml Pass expectedCommentAuthorUserName to both PushPackagesPublishReleaseUnlockAndPostNoticeOnPrepareReleasePullRequest and TryPostReleasePublishedNoticeOnPrepareReleasePullRequest
build/scripts/post-release.psm1 Added expectedCommentAuthorUserName parameter to 3 functions and use it for comment author matching

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

The comments.login is otelbot-dotnet instead of app/otelbot-dotnet
@Kielek Kielek requested a review from a team as a code owner January 21, 2026 08:00
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Jan 21, 2026
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.90%. Comparing base (164d8a5) to head (36bd10c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6842      +/-   ##
==========================================
- Coverage   86.92%   86.90%   -0.03%     
==========================================
  Files         263      263              
  Lines       12382    12382              
==========================================
- Hits        10763    10760       -3     
- Misses       1619     1622       +3     
Flag Coverage Δ
unittests-Project-Experimental 86.75% <ø> (-0.08%) ⬇️
unittests-Project-Stable 86.80% <ø> (+<0.01%) ⬆️
unittests-Solution 86.47% <ø> (-0.43%) ⬇️
unittests-UnstableCoreLibraries-Experimental 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

@Kielek Kielek enabled auto-merge January 21, 2026 08:08
@Kielek Kielek added this pull request to the merge queue Jan 21, 2026
Merged via the queue into open-telemetry:main with commit 4b5ca66 Jan 21, 2026
84 of 85 checks passed
@Kielek Kielek deleted the fix-build-pipeline branch January 21, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix push-packages-and-publish-release step

2 participants