SQL++ (Couchbase N1QL) support #1210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-sql++ # Conflicts: # pkg/appolly/app/request/span.go
mmat11
approved these changes
Jan 29, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
- Coverage 43.10% 42.92% -0.19%
==========================================
Files 299 300 +1
Lines 32120 32476 +356
==========================================
+ Hits 13846 13939 +93
- Misses 17380 17629 +249
- Partials 894 908 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rafaelroquetto
approved these changes
Jan 29, 2026
| return "", "" | ||
| } | ||
|
|
||
| parts := strings.Split(table, ".") |
Contributor
There was a problem hiding this comment.
consider split.NewIterator instead to prevent the allocation of a new slice each time.
Here's an example: https://github.com/open-telemetry/opentelemetry-ebpf-instrumentation/blob/main/pkg/ebpf/common/redis_detect_transform.go#L116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for SQL++ (previously Couchbase N1QL), which is a sql query language over json http.
even though mainly used by couchbase as a complimentary way to query data beside the KV protocol, is also used by other databases like apache AsterixDB, so i think it has a justification to be separated to a different protocol
resolves #1167
Checklist