fix(examples): align otel-collector builder-config with v0.151.0 release line#2420
fix(examples): align otel-collector builder-config with v0.151.0 release line#2420hitkall wants to merge 1 commit into
Conversation
|
|
cf8d189 to
d53ba92
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
==========================================
- Coverage 69.10% 62.23% -6.87%
==========================================
Files 325 324 -1
Lines 42650 35222 -7428
==========================================
- Hits 29475 21922 -7553
- Misses 11474 11859 +385
+ Partials 1701 1441 -260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d53ba92 to
ac82add
Compare
|
|
||
| - Go 1.25 or later | ||
| - [OTel Collector Builder (`ocb`)](https://opentelemetry.io/docs/collector/extend/ocb/) installed | ||
| - [OTel Collector Builder (`ocb`)](https://opentelemetry.io/docs/collector/extend/ocb/) **v0.151.0 or later** installed. The component versions pinned in `builder-config.yaml` track the OpenTelemetry Collector `v0.151.0` release line (matching OBI's own `go.mod`), so `ocb` must be from that release line or newer. Older `ocb` releases may fail to build with undefined-symbol errors. |
There was a problem hiding this comment.
I'm hesitant to say "or later" here. There is no compatibility guarntee for that unstable package.
There was a problem hiding this comment.
Good point, agreed. I dropped the "or later" wording and pinned the doc to v0.151.0, with a note that ocb is an unstable v0.x package with no compatibility guarantee across versions, so the ocb version should match the component versions in builder-config.yaml. The CI job installs ocb at exactly the version resolved from go.mod, so it stays in lockstep too.
…ase line The examples/otel-collector builder-config.yaml pinned Collector components to the v0.145.0 / v1.51.0 release line, which has drifted from the v0.151.0 line OBI depends on (see go.mod). Building with a current ocb failed with undefined symbols in xexporterhelper. - Bump beta modules (debugexporter, otlpexporter, batchprocessor, otlpreceiver) v0.145.0 -> v0.151.0 - Bump stable confmap providers v1.51.0 -> v1.57.0 - Document the ocb version (v0.151.0) the example builds with in the README - Add an "OTel Collector example (ocb build)" job to pull_request.yml that reuses the existing generate-bpf artifact (like collector-cross-compile) and builds the example with ocb, pinned to the Collector version resolved from go.mod so it cannot drift again Fixes open-telemetry#2264
ac82add to
a0e6efb
Compare
MrAlias
left a comment
There was a problem hiding this comment.
Awesome! Thanks for the fix
Description
The
examples/otel-collectorexample fails to build because the component versions inexamples/otel-collector/builder-config.yamlhave drifted out of sync with the Collector release line OBI itself depends on. The config pinned components to thev0.145.0/v1.51.0line, while the repo's rootgo.modis onv0.151.0(stable modules atv1.57.0). Building with a currentocbfails with undefined symbols inxexporterhelper.This PR realigns every component to the
v0.151.0release line (matchinggo.mod), without changing which components are included.Changes
builder-config.yaml— bump components to OBI's Collector release line:v0.145.0→v0.151.0:debugexporter,otlpexporter,batchprocessor,otlpreceiverv1.51.0→v1.57.0:envprovider,fileprovider,httpprovider,httpsprovider,yamlproviderREADME.md— document the minimum compatibleocbversion (v0.151.0+) and why it must trackgo.mod..github/workflows/pull_request_otel_collector_example.ymlthat runs theocbbuild on PRs/pushes touchingexamples/otel-collector/**orgo.mod. It resolves theocbversion fromgo.modso the example can't silently drift again.Testing
Built locally with
ocb/builderv0.151.0:Fixes #2264
🤖 Generated with Claude Code